Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4477)

Unified Diff: chrome/browser/ui/views/profile_chooser_view.cc

Issue 199533004: [Mac, Win] Show a user manager tutorial once per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: alexei comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/gtk/user_manager_gtk.cc ('k') | chrome/browser/ui/views/user_manager_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profile_chooser_view.cc b/chrome/browser/ui/views/profile_chooser_view.cc
index 20c3b73c6e7ab32ffbe7d03f85cf1de60bb43848..1fdaea5419f588dcf16a5ee8a45278bdd6ed8fef 100644
--- a/chrome/browser/ui/views/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profile_chooser_view.cc
@@ -517,13 +517,10 @@ void ProfileChooserView::ButtonPressed(views::Button* sender,
} else if (sender == end_guest_button_) {
profiles::CloseGuestProfileWindows();
} else if (sender == users_button_) {
- // Only non-guest users appear in the User Manager.
- base::FilePath profile_path;
- if (!end_guest_button_) {
- size_t active_index = avatar_menu_->GetActiveProfileIndex();
- profile_path = avatar_menu_->GetItemAt(active_index).profile_path;
- }
- chrome::ShowUserManager(profile_path);
+ if (end_guest_button_)
Alexei Svitkine (slow) 2014/03/19 16:37:01 Can you preserve some comment explaining this if s
Alexei Svitkine (slow) 2014/03/19 16:37:01 Can you avoid having the logic to call the differe
noms (inactive) 2014/03/19 17:10:38 Done.
noms (inactive) 2014/03/19 17:10:38 Done.
+ chrome::ShowUserManager(base::FilePath());
+ else
+ profiles::ShowUserManagerMaybeWithTutorial(browser_->profile());
} else if (sender == add_user_button_) {
profiles::CreateAndSwitchToNewProfile(
browser_->host_desktop_type(),
« no previous file with comments | « chrome/browser/ui/gtk/user_manager_gtk.cc ('k') | chrome/browser/ui/views/user_manager_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698