[Mac, Win] Show a user manager tutorial once per profile.

chrome/browser/ui/views/profile_chooser_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile_info_util.h"
@@ skipping 499 matching lines @@
   // has no parent (like in tests) because that will also crash.
   if (sender->parent())
     sender->SetEnabled(false);
 
   if (sender == guest_button_) {
     profiles::SwitchToGuestProfile(browser_->host_desktop_type(),
                                    profiles::ProfileSwitchingDoneCallback());
   } else if (sender == end_guest_button_) {
     profiles::CloseGuestProfileWindows();
   } else if (sender == users_button_) {
-    // Only non-guest users appear in the User Manager.
-    base::FilePath profile_path;
-    if (!end_guest_button_) {
-      size_t active_index = avatar_menu_->GetActiveProfileIndex();
-      profile_path = avatar_menu_->GetItemAt(active_index).profile_path;
-    }
-    chrome::ShowUserManager(profile_path);
+    if (end_guest_button_)

[Alexei Svitkine (slow), 2014/03/19 16:37:01]

Can you preserve some comment explaining this if statement?

[Alexei Svitkine (slow), 2014/03/19 16:37:01]

Can you avoid having the logic to call the different functions by just passing a
NULL profile in the guest case?

i.e.

profiles::ShowUserManagerMaybeWithTutorial(
    end_guest_button_ ? NULL : browser_->profile());

[noms (inactive), 2014/03/19 17:10:38]

Done.

[noms (inactive), 2014/03/19 17:10:38]

Done.

+      chrome::ShowUserManager(base::FilePath());
+    else
+      profiles::ShowUserManagerMaybeWithTutorial(browser_->profile());
   } else if (sender == add_user_button_) {
     profiles::CreateAndSwitchToNewProfile(
         browser_->host_desktop_type(),
         profiles::ProfileSwitchingDoneCallback(),
         ProfileMetrics::ADD_NEW_USER_ICON);
   } else if (sender == add_account_button_) {
     ShowView(GAIA_ADD_ACCOUNT_VIEW, avatar_menu_.get());
   } else if (sender == current_profile_photo_->change_photo_button()) {
     avatar_menu_->EditProfile(avatar_menu_->GetActiveProfileIndex());
   } else if (sender == tutorial_ok_button_) {
@@ skipping 405 matching lines @@
   if (!is_primary_account) {
     email_button->set_menu_marker(menu_marker);
     layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
   }
   layout->StartRow(1, 0);
   layout->AddView(email_button);
 
   // Save the original email address, as the button text could be elided.
   current_profile_accounts_map_[email_button] = account;
 }