Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1995313002: MIPS: Fix function Fast_ArrayConcat. (Closed)

Created:
4 years, 7 months ago by Ilija.Pavlovic1
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix function Fast_ArrayConcat. Port for https://codereview.chromium.org/1409123003 In function Fast_ArrayConcat is added comparation between result_len and FixedDoubleArray::kMaxLength. This change enables successful execution of the test regress-599414-array-concat-fast-path. Original commit message: [runtime] Avoid @@isConcatSpreadable lookup for fast path Array.prototype.concat Currently we do not check for @@isConcatSpreadable properly. If the Symbol is set on the Array.prototype or Object.prototype the current fast paths fail. This CL adds a fix to globally invalidate a isConcatSpreadable_protector. Drive-by-fix: use named accessors for context variables TEST=mjsunit/regress/regress-599414-array-concat-fast-path BUG= Committed: https://crrev.com/e2e879694af027fde9c6f003a5281a135a5ba45f Cr-Commit-Position: refs/heads/master@{#36429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/builtins.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Ilija.Pavlovic1
PTAL
4 years, 7 months ago (2016-05-20 10:40:56 UTC) #2
balazs.kilvady
lgtm. This does need a v8-team review. Can one of you PTAL?
4 years, 7 months ago (2016-05-20 11:04:50 UTC) #3
Camillo Bruni
lgtm
4 years, 7 months ago (2016-05-20 13:19:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995313002/1
4 years, 7 months ago (2016-05-23 06:34:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 07:07:28 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 07:09:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2e879694af027fde9c6f003a5281a135a5ba45f
Cr-Commit-Position: refs/heads/master@{#36429}

Powered by Google App Engine
This is Rietveld 408576698