src/builtins.cc - Issue 1995313002: MIPS: Fix function Fast_ArrayConcat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1995313002: MIPS: Fix function Fast_ArrayConcat. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index d869fd0961b1413f4843f4cb8c0787dbb419fb45..7f9652c9cdad14c569f5b46d41a36f337636f256 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -1471,7 +1471,8 @@ MaybeHandle<JSArray> Fast_ArrayConcat(Isolate* isolate, Arguments* args) {

result_len += Smi::cast(array->length())->value();

DCHECK(result_len >= 0);

// Throw an Error if we overflow the FixedArray limits

- if (FixedArray::kMaxLength < result_len) {

+ if (FixedDoubleArray::kMaxLength < result_len ||

+ FixedArray::kMaxLength < result_len) {

AllowHeapAllocation gc;

THROW_NEW_ERROR(isolate,

NewRangeError(MessageTemplate::kInvalidArrayLength),

« no previous file with comments | « no previous file | no next file » | no next file with comments »