Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1995303002: [interpreter] Fix source position of yield-exceptions in generators. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
rmcilroy, Yang
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix source position of yield-exceptions in generators. R=rmcilroy@chromium.org BUG=v8:4907, v8:5027 Committed: https://crrev.com/b3bfc0bd58b07232da08c1d6e7504c55b4e80710 Cr-Commit-Position: refs/heads/master@{#36421}

Patch Set 1 #

Patch Set 2 : Rebaseline bytecode expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M src/interpreter/bytecode-array-builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 2 chunks +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 5 chunks +5 lines, -5 lines 0 comments Download
A + test/message/generators-throw1.js View 1 chunk +4 lines, -5 lines 0 comments Download
A test/message/generators-throw1.out View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/message/generators-throw2.js View 1 chunk +6 lines, -5 lines 0 comments Download
A test/message/generators-throw2.out View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
neis
4 years, 7 months ago (2016-05-20 10:33:43 UTC) #1
neis
PTAL. Alternatively, builder->Return() could take a boolean set_return_position as argument. Then we don't need to ...
4 years, 7 months ago (2016-05-20 10:34:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995303002/20001
4 years, 7 months ago (2016-05-20 13:11:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-20 13:41:39 UTC) #6
rmcilroy
+Yang for FYI LGTM, thanks.
4 years, 7 months ago (2016-05-20 14:24:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995303002/20001
4 years, 7 months ago (2016-05-20 16:05:52 UTC) #9
Yang
On 2016/05/20 16:05:52, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 7 months ago (2016-05-20 16:29:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 17:48:42 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 17:51:03 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b3bfc0bd58b07232da08c1d6e7504c55b4e80710
Cr-Commit-Position: refs/heads/master@{#36421}

Powered by Google App Engine
This is Rietveld 408576698