src/interpreter/bytecode-generator.cc - Issue 1995303002: [interpreter] Fix source position of yield-exceptions in generators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 1995303002: [interpreter] Fix source position of yield-exceptions in generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebaseline bytecode expectations Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index 650234a58447d506cd28659f0a9c4c49bd38a332..866351e9d967f33fd257ac62c7a67aafcbdf4010 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -218,6 +218,7 @@ class BytecodeGenerator::ControlScopeForTopLevel final

case CMD_CONTINUE:

UNREACHABLE();

case CMD_RETURN:

+ generator()->builder()->SetReturnPosition();

generator()->builder()->Return();

return true;

case CMD_RETHROW:

« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »