Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1995243002: Add OBB mounter Mojo interface (Closed)

Created:
4 years, 7 months ago by hashimoto
Modified:
4 years, 7 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, hidehiko+watch_chomium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add OBB mounte Mojo interface Add a new interface ObbMounter, and expose it to Android. Actual features are not implemented yet. BUG=613480 Committed: https://crrev.com/4265d7151753f4e3a7a4cbe688b423c376dd9503 Cr-Commit-Position: refs/heads/master@{#395557} Committed: https://crrev.com/593d78aa7f3dd422ae42723c2dc039b7059704da Cr-Commit-Position: refs/heads/master@{#395572}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rebase & alphabetical order #

Total comments: 2

Patch Set 3 : Add a comment #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -2 lines) Patch
M components/arc.gypi View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M components/arc/BUILD.gn View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service.h View 1 2 3 4 8 chunks +14 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 2 3 4 3 chunks +29 lines, -0 lines 0 comments Download
M components/arc/arc_service_manager.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
A components/arc/common/obb_mounter.mojom View 1 chunk +20 lines, -0 lines 0 comments Download
A components/arc/obb_mounter/arc_obb_mounter_bridge.h View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A components/arc/obb_mounter/arc_obb_mounter_bridge.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (18 generated)
hashimoto
4 years, 7 months ago (2016-05-20 07:58:17 UTC) #4
hidehiko
https://codereview.chromium.org/1995243002/diff/40001/components/arc/common/arc_bridge.mojom File components/arc/common/arc_bridge.mojom (right): https://codereview.chromium.org/1995243002/diff/40001/components/arc/common/arc_bridge.mojom#newcode81 components/arc/common/arc_bridge.mojom:81: [MinVersion=12] OnObbMounterInstanceReady@118(ObbMounterInstance instance_ptr); ID looks conflicting. Could you rebase?
4 years, 7 months ago (2016-05-20 14:15:46 UTC) #5
hashimoto
https://codereview.chromium.org/1995243002/diff/40001/components/arc/common/arc_bridge.mojom File components/arc/common/arc_bridge.mojom (right): https://codereview.chromium.org/1995243002/diff/40001/components/arc/common/arc_bridge.mojom#newcode81 components/arc/common/arc_bridge.mojom:81: [MinVersion=12] OnObbMounterInstanceReady@118(ObbMounterInstance instance_ptr); On 2016/05/20 14:15:46, hidehiko wrote: > ...
4 years, 7 months ago (2016-05-23 04:46:47 UTC) #6
hidehiko
+rickyz. Ricky, could you review mojom files as an OWNER? LGTM for components/arc. https://codereview.chromium.org/1995243002/diff/60001/components/arc/obb_mounter/arc_obb_mounter_bridge.h File ...
4 years, 7 months ago (2016-05-23 09:14:47 UTC) #11
rickyz (no longer on Chrome)
On 2016/05/23 at 09:14:47, hidehiko wrote: > +rickyz. > > Ricky, could you review mojom ...
4 years, 7 months ago (2016-05-24 04:39:58 UTC) #12
hashimoto
https://codereview.chromium.org/1995243002/diff/60001/components/arc/obb_mounter/arc_obb_mounter_bridge.h File components/arc/obb_mounter/arc_obb_mounter_bridge.h (right): https://codereview.chromium.org/1995243002/diff/60001/components/arc/obb_mounter/arc_obb_mounter_bridge.h#newcode15 components/arc/obb_mounter/arc_obb_mounter_bridge.h:15: class ArcObbMounterBridge : public ArcService, On 2016/05/23 09:14:47, hidehiko ...
4 years, 7 months ago (2016-05-24 06:32:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995243002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995243002/120001
4 years, 7 months ago (2016-05-24 09:37:19 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 7 months ago (2016-05-24 09:41:42 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/4265d7151753f4e3a7a4cbe688b423c376dd9503 Cr-Commit-Position: refs/heads/master@{#395557}
4 years, 7 months ago (2016-05-24 09:44:37 UTC) #20
hashimoto
A revert of this CL (patchset #4 id:120001) has been created in https://codereview.chromium.org/2001013004/ by hashimoto@chromium.org. ...
4 years, 7 months ago (2016-05-24 10:12:16 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995243002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995243002/180001
4 years, 7 months ago (2016-05-24 10:36:41 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:180001)
4 years, 7 months ago (2016-05-24 11:44:25 UTC) #29
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 11:45:55 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/593d78aa7f3dd422ae42723c2dc039b7059704da
Cr-Commit-Position: refs/heads/master@{#395572}

Powered by Google App Engine
This is Rietveld 408576698