Test color correction in DM

Test color correction in DM

This will allow me to test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1995233003

Committed: https://skia.googlesource.com/skia/+/888dc16684da2158702639be2023f998b7c27f66

[msarett, 2016-05-20 17:58:29]

Description was changed from

==========
Test color correction in DM

BUG=skia:
==========

to

==========
Test color correction in DM

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-23 15:00:03]

Patchset #2 (id:20001) has been deleted

[msarett, 2016-05-23 15:00:10]

Patchset #1 (id:1) has been deleted

[msarett, 2016-05-23 15:04:27]

Description was changed from

==========
Test color correction in DM

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test color correction in DM

This will allow to me test and visualize some assumptions on parsing and
applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-23 15:04:59]

Description was changed from

==========
Test color correction in DM

This will allow to me test and visualize some assumptions on parsing and
applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test color correction in DM

This will allow to me test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-23 15:16:13]

Patchset #1 (id:40001) has been deleted

[msarett, 2016-05-23 15:16:45]

Description was changed from

==========
Test color correction in DM

This will allow to me test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test color correction in DM

This will allow me to test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-05-23 15:18:32]

Patchset #1 (id:60001) has been deleted

[msarett, 2016-05-23 15:19:06]

msarett@google.com changed reviewers:
+ reed@google.com, scroggo@google.com

[scroggo, 2016-05-23 16:12:38]

lgtm

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:871: uint32_t width = info.width();
Why did you store these in local variables? It looks like you only use them
once, down below?

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:899: // testing.  Once we support all of them, this should be a
fatal error.
FIXME?

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:925: // Conver to dst gamut.
Convert*

[msarett, 2016-05-23 16:17:50]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 16:17:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995233003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995233003/100001

[msarett, 2016-05-23 16:19:53]

Patchset #2 (id:100001) has been deleted

[msarett, 2016-05-23 16:20:03]

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:871: uint32_t width = info.width();
On 2016/05/23 16:12:38, scroggo wrote:
> Why did you store these in local variables? It looks like you only use them
> once, down below?

Can't remember, I think a draft implementation may have used them more times...

I've removed the local variables.

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:899: // testing.  Once we support all of them, this should be a
fatal error.
On 2016/05/23 16:12:38, scroggo wrote:
> FIXME?

Done.

https://codereview.chromium.org/1995233003/diff/80001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:925: // Conver to dst gamut.
On 2016/05/23 16:12:38, scroggo wrote:
> Convert*

Done.

[msarett, 2016-05-23 16:20:11]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 16:20:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995233003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995233003/120001

[commit-bot: I haz the power, 2016-05-23 16:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 16:34:36]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[msarett, 2016-05-23 16:43:21]

The CQ bit was checked by msarett@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 16:43:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995233003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995233003/140001

[scroggo, 2016-05-23 16:57:25]

https://codereview.chromium.org/1995233003/diff/140001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1995233003/diff/140001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:888: case kDst_HPZR30w_Mode: {
It almost seems like this should be a Sink. But it doesn't quite fit in with our
current setup.

[commit-bot: I haz the power, 2016-05-23 16:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 16:57:57]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-05-23 17:07:58]

https://codereview.chromium.org/1995233003/diff/140001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/1995233003/diff/140001/dm/DMSrcSink.cpp#newco...
dm/DMSrcSink.cpp:888: case kDst_HPZR30w_Mode: {
On 2016/05/23 16:57:25, scroggo wrote:
> It almost seems like this should be a Sink. But it doesn't quite fit in with
our
> current setup.

You're right that actually makes more logical sense.

I *think* the tricky part would be communicating the srcSpace to the Sink (or
communicating the dstSpace to the Src).

I'll probably land this as is and look into this idea if/when I try to add to
more dsts.

[msarett, 2016-05-23 17:19:52]

The CQ bit was checked by msarett@google.com

[msarett, 2016-05-23 17:19:52]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1995233003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2016-05-23 17:20:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995233003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995233003/140001

[commit-bot: I haz the power, 2016-05-23 17:21:19]

Description was changed from

==========
Test color correction in DM

This will allow me to test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test color correction in DM

This will allow me to test and visualize some assumptions
on parsing and applying color profiles.  Also, it should
help me find and fix bugs.

This is certainly not an optimized implementation, and, as
far as I know, it doesn't take any shortcuts to improve
performance.  We'll probably want to do both of these
once we know where it fits in the pipeline.

Right now this test is only run on an arbitrary set of ~100
images from the top 10k skps.  I'll continue to add more
"interesting" images and probably tweak the code as
necessary.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/888dc16684da2158702639be2023f998b7c27f66
==========

[commit-bot: I haz the power, 2016-05-23 17:21:21]

Committed patchset #3 (id:140001) as
https://skia.googlesource.com/skia/+/888dc16684da2158702639be2023f998b7c27f66