Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: dm/DMSrcSink.h

Issue 1995233003: Test color correction in DM (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMSrcSink.cpp » ('j') | dm/DMSrcSink.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMSrcSink.h
diff --git a/dm/DMSrcSink.h b/dm/DMSrcSink.h
index b0f67dbb2989fb36d15d799c659e8c89257459b1..84096bf0fe9ab4f2ca31af3bc152502836581053 100644
--- a/dm/DMSrcSink.h
+++ b/dm/DMSrcSink.h
@@ -204,9 +204,17 @@ public:
enum Mode {
// Mimic legacy behavior and apply no color correction.
kBaseline_Mode,
+
+ // Color correct images into a specific dst color space. If you happen to have this
+ // monitor, you're in luck! The unmarked outputs of this test should display
+ // correctly on this monitor in the Chrome browser. If not, it's useful to know
+ // that this monitor has a profile that is fairly similar to Adobe RGB.
+ // TODO (msarett): Should we add a new test with a new monitor and verify that outputs
+ // look identical on two different dsts?
+ kDst_HPZR30w_Mode,
};
- ColorCodecSrc(Path, Mode);
+ ColorCodecSrc(Path, Mode, sk_sp<SkColorSpace>);
Error draw(SkCanvas*) const override;
SkISize size() const override;
@@ -215,6 +223,7 @@ public:
private:
Path fPath;
Mode fMode;
+ sk_sp<SkColorSpace> fDstSpace;
};
class SKPSrc : public Src {
« no previous file with comments | « dm/DM.cpp ('k') | dm/DMSrcSink.cpp » ('j') | dm/DMSrcSink.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698