[Findit] Use build_parameter to pass tests(Recipe side).

Use build_parameter to pass tests, and in recipe use buildbucket recipe module and read test list from there.

BUG=612979
Committed: https://chromium.googlesource.com/chromium/tools/build/+/3aa19451a821eb7e1d161e542aa6d0fc17ba416c

[chanli, 2016-05-19 21:52:41]

Description was changed from

==========
.

BUG=
==========

to

==========
Use build_parameter to pass tests, and in recipe use buildbucket recipe module
and read test list from there.

BUG=612979
==========

[chanli, 2016-05-20 18:36:18]

chanli@chromium.org changed reviewers:
+ lijeffrey@chromium.org, stgao@chromium.org

[chanli, 2016-05-20 18:36:18]

ptal

[stgao, 2016-05-20 18:53:47]

I guess some test needs updating too, or a new test should be added.

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:49: 'buildbucket': Property(
How about keeping both "tests" and "buildbucket" optional, but one of them
should exist?

If "tests" is not available, read from "buildbucket".
In this case, there won't be any breakage in case the either the recipe or the
findit app deployment run into some unexpected blocking.

[lijeffrey, 2016-05-20 20:47:56]

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:188: bad_revision, buildbucket,
use_analyze, suspected_revisions):
nit: rename this buildbucket_data or something similar

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:195: 'additional_parameters',
{}).get('tests')
if you rename this to 'build_parameters' like Shuotao suggested in your other
review make sure to change it here too

[chanli, 2016-05-20 21:07:38]

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
File scripts/slave/recipes/findit/chromium/test.py (right):

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:49: 'buildbucket': Property(
On 2016/05/20 18:53:46, stgao wrote:
> How about keeping both "tests" and "buildbucket" optional, but one of them
> should exist?
> 
> If "tests" is not available, read from "buildbucket".
> In this case, there won't be any breakage in case the either the recipe or the
> findit app deployment run into some unexpected blocking.

Good idea. Done.

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:188: bad_revision, buildbucket,
use_analyze, suspected_revisions):
On 2016/05/20 20:47:55, lijeffrey wrote:
> nit: rename this buildbucket_data or something similar

I'll leave it as is since this property is passed in as 'buildbucket'.

https://codereview.chromium.org/1995153002/diff/20001/scripts/slave/recipes/f...
scripts/slave/recipes/findit/chromium/test.py:195: 'additional_parameters',
{}).get('tests')
On 2016/05/20 20:47:55, lijeffrey wrote:
> if you rename this to 'build_parameters' like Shuotao suggested in your other
> review make sure to change it here too

Done.

[stgao, 2016-05-20 21:30:06]

lgtm

It would be great if we could include some doc on how to setup properly in a
local env to run a try-job locally.

[lijeffrey, 2016-05-20 21:42:05]

lgtm

[chanli, 2016-05-20 23:54:54]

The CQ bit was checked by chanli@chromium.org

[commit-bot: I haz the power, 2016-05-20 23:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995153002/40001

[commit-bot: I haz the power, 2016-05-21 00:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 00:02:13]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[chanli, 2016-05-21 00:06:35]

The CQ bit was checked by chanli@chromium.org

[chanli, 2016-05-21 00:06:35]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org,
lijeffrey@chromium.org
Link to the patchset: https://codereview.chromium.org/1995153002/#ps60001
(title: "update test expect")

[commit-bot: I haz the power, 2016-05-21 00:06:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995153002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995153002/60001

[commit-bot: I haz the power, 2016-05-21 00:10:19]

Description was changed from

==========
Use build_parameter to pass tests, and in recipe use buildbucket recipe module
and read test list from there.

BUG=612979
==========

to

==========
Use build_parameter to pass tests, and in recipe use buildbucket recipe module
and read test list from there.

BUG=612979

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/3aa19451a821eb7e1d16...
==========

[commit-bot: I haz the power, 2016-05-21 00:10:20]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/3aa19451a821eb7e1d16...