[Findit] Use build_parameter to pass tests(Recipe side).

scripts/slave/recipes/findit/chromium/test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import json
 
 from recipe_engine.config import Dict
 from recipe_engine.config import List
 from recipe_engine.config import Single
 from recipe_engine.recipe_api import Property
 
 
 DEPS = [
     'adb',
+    'buildbucket',
     'depot_tools/bot_update',
     'chromium',
     'chromium_android',
     'chromium_tests',
     'commit_position',
     'findit',
     'depot_tools/gclient',
     'isolate',
     'recipe_engine/json',
     'recipe_engine/path',
@@ skipping 12 matching lines @@
     'target_mastername': Property(
         kind=str, help='The target master to match compile config to.'),
     'target_testername': Property(
         kind=str,
         help='The target tester to match test config to. If the tests are run '
              'on a builder, just treat the builder as a tester.'),
     'good_revision': Property(
         kind=str, help='The last known good revision.'),
     'bad_revision': Property(
         kind=str, help='The first known good revision.'),
-    'tests': Property(
-        kind=Dict(value_type=list),
-        help='The failed tests, the test name should be full name, e.g.: {'
-             '  "browser_tests": ['
-             '    "suite.test1", "suite.test2"'
-             '  ]'
-             '}'),
+    'buildbucket': Property(

[stgao, 2016/05/20 18:53:46]

How about keeping both "tests" and "buildbucket" optional, but one of them
should exist?

If "tests" is not available, read from "buildbucket".
In this case, there won't be any breakage in case the either the recipe or the
findit app deployment run into some unexpected blocking.

[chanli, 2016/05/20 21:07:37]

Good idea. Done.

+        help='The buildbucket property in which we can find build id.'
+             'We need to use build id to get tests.'),
     'use_analyze': Property(
         kind=Single(bool, empty_val=False, required=False), default=True,
         help='Use analyze to skip commits that do not affect tests.'),
     'suspected_revisions': Property(
         kind=List(basestring), default=[],
         help='A list of suspected revisions from heuristic analysis.'),
 }
 
 
 class TestResult(object):
@@ skipping 116 matching lines @@
     if step in failed_tests_dict:
       for test in tests:
         if test not in failed_tests_dict[step]:
           reduced_dict[step].append(test)
     else:
       reduced_dict[step].extend(tests)
   return reduced_dict
 
 
 def RunSteps(api, target_mastername, target_testername, good_revision,
-             bad_revision, tests, use_analyze, suspected_revisions):
+             bad_revision, buildbucket, use_analyze, suspected_revisions):

[lijeffrey, 2016/05/20 20:47:55]

nit: rename this buildbucket_data or something similar

[chanli, 2016/05/20 21:07:37]

I'll leave it as is since this property is passed in as 'buildbucket'.

+
+  buildbucket_json = json.loads(buildbucket)
+  build_id = buildbucket_json['build']['id']
+  get_build_result = api.buildbucket.get_build(build_id)
+  tests = json.loads(
+      get_build_result.stdout['build']['parameters_json']).get(
+          'additional_parameters', {}).get('tests')

[lijeffrey, 2016/05/20 20:47:55]

if you rename this to 'build_parameters' like Shuotao suggested in your other
review make sure to change it here too

[chanli, 2016/05/20 21:07:38]

Done.

+
   assert tests, 'No failed tests were specified.'
 
   # Figure out which builder configuration we should match for compile config.
   # Sometimes, the builder itself runs the tests and there is no tester. In
   # such cases, just treat the builder as a "tester". Thus, we default to
   # the target tester.
   tester_config = api.chromium_tests.builders.get(
       target_mastername).get('builders', {}).get(target_testername)
   target_buildername = (tester_config.get('parent_buildername') or
                         target_testername)
@@ skipping 764 matching lines @@
               'notice': [
                   {
                       'infra_status': {
                           'ping_status_code': 408,
                       },
                   },
               ],
           }),
           retcode=1)
   )