Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1995133002: cc : Delete ResetFlags in property trees (Closed)

Created:
4 years, 7 months ago by jaydasika
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Delete ResetFlags in property trees We had different reset flags because opacity changes used to force rebuild of property trees on main thread and so we had no change tracking on effect tree on the main thread. But, now since opacity chnages don't force rebuild and its possible to do change tracking on effect tree on the main thread, we have to reset change tracking on both transform and effect trees every time. So, this flag is no longer needed. BUG=609205 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d6f778b77449dd684b12b843abb281a1fb7fc949 Cr-Commit-Position: refs/heads/master@{#394891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -61 lines) Patch
M cc/layers/layer_impl_unittest.cc View 7 chunks +7 lines, -14 lines 0 comments Download
M cc/layers/layer_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/property_tree.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +3 lines, -12 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jaydasika
PTAL
4 years, 7 months ago (2016-05-19 20:47:04 UTC) #4
ajuma
lgtm
4 years, 7 months ago (2016-05-19 21:07:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1995133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1995133002/1
4 years, 7 months ago (2016-05-19 21:10:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 22:51:40 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 22:53:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6f778b77449dd684b12b843abb281a1fb7fc949
Cr-Commit-Position: refs/heads/master@{#394891}

Powered by Google App Engine
This is Rietveld 408576698