cc/trees/layer_tree_host_unittest.cc - Issue 1995133002: cc : Delete ResetFlags in property trees

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 1995133002: cc : Delete ResetFlags in property trees (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/layer_tree_host_unittest.cc

diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc

index bc323213af2ab10401bcb397de66810bd84c9399..7f6e735de531bacdd26dfdf679a0a84fda6da1ce 100644

--- a/cc/trees/layer_tree_host_unittest.cc

+++ b/cc/trees/layer_tree_host_unittest.cc

@@ -837,8 +837,7 @@ class LayerTreeHostTestDamageWithReplica : public LayerTreeHostTest {

void CommitCompleteOnThread(LayerTreeHostImpl* impl) override {

switch (index_) {

case 0:

- impl->sync_tree()->ResetAllChangeTracking(

- PropertyTrees::ResetFlags::ALL_TREES);

+ impl->sync_tree()->ResetAllChangeTracking();

EXPECT_FALSE(impl->sync_tree()->root_layer()->LayerPropertyChanged());

PostSetNeedsCommitToMainThread();

index_++;

@@ -900,8 +899,7 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {

switch (static_cast<Animations>(index_)) {

case OPACITY:

index_++;

- impl->active_tree()->ResetAllChangeTracking(

- PropertyTrees::ResetFlags::ALL_TREES);

+ impl->active_tree()->ResetAllChangeTracking();

impl->active_tree()->root_layer()->OnOpacityAnimated(0.5f);

PostSetNeedsCommitToMainThread();

break;

@@ -910,8 +908,7 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {

EXPECT_TRUE(impl->active_tree()

->LayerById(root_->id())

->LayerPropertyChanged());

- impl->active_tree()->ResetAllChangeTracking(

- PropertyTrees::ResetFlags::EFFECT_TREE);

+ impl->active_tree()->ResetAllChangeTracking();

EXPECT_FALSE(impl->active_tree()

->LayerById(root_->id())

->LayerPropertyChanged());

@@ -928,8 +925,7 @@ class LayerTreeHostTestPropertyTreesChangedSync : public LayerTreeHostTest {

EXPECT_TRUE(impl->active_tree()

->LayerById(child_->id())

->LayerPropertyChanged());

- impl->active_tree()->ResetAllChangeTracking(

- PropertyTrees::ResetFlags::TRANSFORM_TREE);

+ impl->active_tree()->ResetAllChangeTracking();

EXPECT_FALSE(impl->active_tree()->root_layer()->LayerPropertyChanged());

EXPECT_FALSE(impl->active_tree()

->LayerById(child_->id())

« no previous file with comments | « cc/trees/layer_tree_host_impl.cc ('k') | cc/trees/layer_tree_impl.h » ('j') | no next file with comments »