Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1994933002: [heap] Get rid of the wrapper in remembered-set.h (Closed)

Created:
4 years, 7 months ago by ahaas
Modified:
4 years, 7 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Get rid of the wrapper in remembered-set.h This patch moves the wrapper code from the remembered-set to the scavenger and the mark-compact code. The wrapper code inspected a slot address to see if the object that belongs to the address is in the from-space. If it was in the from-space, then some callback was executed on the object. If the object got move to the to-space, then the wrapper returned KEEP_SLOT, otherwise REMOVE_SLOT. This logic does not really belong to the remembered set, so I moved it away from there. R=ulan@chromium.org Committed: https://crrev.com/3ddb22494d04ec6d49a68e88863a657342421d07 Cr-Commit-Position: refs/heads/master@{#36364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -56 lines) Patch
M src/heap/heap.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +26 lines, -9 lines 0 comments Download
M src/heap/remembered-set.h View 2 chunks +0 lines, -45 lines 0 comments Download
M src/heap/scavenger.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/scavenger-inl.h View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 7 months ago (2016-05-19 12:33:53 UTC) #1
ulan
lgtm, thank you.
4 years, 7 months ago (2016-05-19 13:13:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994933002/1
4 years, 7 months ago (2016-05-19 13:15:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:17:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:18:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ddb22494d04ec6d49a68e88863a657342421d07
Cr-Commit-Position: refs/heads/master@{#36364}

Powered by Google App Engine
This is Rietveld 408576698