Add !IsArray() check for dictionary conversion in union types

third_party/WebKit/Source/bindings/templates/union_container.cpp

Index: third_party/WebKit/Source/bindings/templates/union_container.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/union_container.cpp b/third_party/WebKit/Source/bindings/templates/union_container.cpp
index 8ad45d0c7bc4b3dea841c57656a0d82cb3bea988..fff571776a7a7b89053c0d0fc5961cc06e983190 100644
--- a/third_party/WebKit/Source/bindings/templates/union_container.cpp
+++ b/third_party/WebKit/Source/bindings/templates/union_container.cpp
@@ -93,7 +93,9 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{
     {# 12. Dictionaries #}
     {# FIXME: This should also check "object but not Date or RegExp". Add checks
        when we implement conversions for Date and RegExp. #}
-    if (isUndefinedOrNull(v8Value) || v8Value->IsObject()) {
+    {# TODO(bashi): The spec doesn't say we should check !IsArray() but otherwise
+       we can't distinguish a sequence<T> and a dictionary. #}

[hta - Chromium, 2016/05/19 06:38:35]

Should there be a link to the bug filed against the spec here?

[bashi, 2016/05/19 08:21:14]

Done.

+    if (isUndefinedOrNull(v8Value) || (v8Value->IsObject() && !v8Value->IsArray())) {
         {{v8_value_to_local_cpp_value(dictionary_type) | indent(8)}}
         impl.set{{dictionary_type.type_name}}(cppValue);
         return;