Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 1994793002: Delete IDC_CONTENT_CONTEXT_VIEWPAGEINFO and unused strings (Closed)

Created:
4 years, 7 months ago by meacer
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete IDC_CONTENT_CONTEXT_VIEWPAGEINFO and unused strings BUG=506874 Committed: https://crrev.com/6f00924d8c3c8c688b58b527d6180712cc5526eb Cr-Commit-Position: refs/heads/master@{#394852}

Patch Set 1 #

Patch Set 2 : Delete IDS_CONTENT_CONTEXT_VIEWFRAMEINFO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -71 lines) Patch
M chrome/app/generated_resources.grd View 1 6 chunks +2 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_preview_context_menu_observer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 4 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
meacer
edwardjung: Can you PTAL?
4 years, 7 months ago (2016-05-18 21:49:24 UTC) #2
edwardjung
On 2016/05/18 21:49:24, Mustafa Emre Acer wrote: > edwardjung: Can you PTAL? I'm not an ...
4 years, 7 months ago (2016-05-19 09:37:05 UTC) #5
meacer
> I'm not an owner of these files. But LGTM for what it's worth. Thanks, ...
4 years, 7 months ago (2016-05-19 17:45:45 UTC) #7
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-19 18:02:30 UTC) #8
Avi (use Gerrit)
lgtm 👍
4 years, 7 months ago (2016-05-19 18:23:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994793002/20001
4 years, 7 months ago (2016-05-19 18:30:43 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 20:46:03 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:48:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f00924d8c3c8c688b58b527d6180712cc5526eb
Cr-Commit-Position: refs/heads/master@{#394852}

Powered by Google App Engine
This is Rietveld 408576698