Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2748)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Issue 1994793002: Delete IDC_CONTENT_CONTEXT_VIEWPAGEINFO and unused strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete IDS_CONTENT_CONTEXT_VIEWFRAMEINFO Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
index 6e3270c1b12554796763927dcb04110c0d7982d2..d2101d8366a1c62b04bde1fedd6356b9b6204faa 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
@@ -365,31 +365,6 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {
ASSERT_EQ(kSuggestedFilename, base::UTF16ToUTF8(suggested_filename).c_str());
}
-// Ensure that View Page Info won't crash if there is no visible entry.
-// See http://crbug.com/370863.
-IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {
- // Create a new tab with no committed entry.
- ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(
- content::NotificationService::AllSources());
- ASSERT_TRUE(content::ExecuteScript(
- browser()->tab_strip_model()->GetActiveWebContents(), "window.open();"));
- tab_observer.Wait();
- content::WebContents* tab = tab_observer.GetTab();
- EXPECT_FALSE(tab->GetController().GetLastCommittedEntry());
- EXPECT_FALSE(tab->GetController().GetVisibleEntry());
-
- // Create a context menu.
- content::ContextMenuParams context_menu_params;
- TestRenderViewContextMenu menu(tab->GetMainFrame(), context_menu_params);
- menu.Init();
-
- // The item shouldn't be enabled in the menu.
- EXPECT_FALSE(menu.IsCommandIdEnabled(IDC_CONTENT_CONTEXT_VIEWPAGEINFO));
-
- // Ensure that viewing page info doesn't crash even if you can get to it.
- menu.ExecuteCommand(IDC_CONTENT_CONTEXT_VIEWPAGEINFO, 0);
-}
-
IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, DataSaverOpenOrigImageInNewTab) {
base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
command_line->AppendSwitch(
« no previous file with comments | « chrome/browser/renderer_context_menu/render_view_context_menu.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698