Make the dependency of enable_print_preview and enable_pdf explicit

chrome/utility/BUILD.gn

Index: chrome/utility/BUILD.gn
diff --git a/chrome/utility/BUILD.gn b/chrome/utility/BUILD.gn
index 55f36ce06b6789c823ffd30b54cf3a1b411ba521..4af71df6eeaa5cf258f84479b5b7d91377a7881b 100644
--- a/chrome/utility/BUILD.gn
+++ b/chrome/utility/BUILD.gn
@@ -100,11 +100,13 @@ static_library("utility") {
     ]
   }
 
-  if (!enable_print_preview) {
+  if (!enable_print_preview && !is_win) {

[Lei Zhang, 2016/05/18 21:43:37]

Also, "enable_print_preview" used to imply "enable_basic_printing" but later we
changed it so that the two variables are independent of each other. Given that,
this should actually be:

(enable_print_preview || (enable_basic_printing & is_win))

Can we make that change while we are here?
chrome/utility/chrome_content_utility_client.cc and
chrome/utility/printing_handler.h have ifdefs that should be updated as well.

[Lei Zhang, 2016/05/18 21:43:37]

Would you mind negating this?

if (enable_print_preview || is_win) {
  deps += [ "//pdf" ]
} else {
  sources -= [
    "printing_handler.cc",
    "printing_handler.h",
  ]
}

[Wei Li, 2016/05/19 17:13:30]

Thanks for the explanation. Done. 

[Wei Li, 2016/05/19 17:13:30]

Done.

[Wei Li, 2016/05/19 17:13:30]

Thanks for the explanation. Done. 

     sources -= [
       "printing_handler.cc",
       "printing_handler.h",
     ]
+  } else {
+    deps += [ "//pdf" ]
   }
 
   if (safe_browsing_mode == 1) {
@@ -112,10 +114,6 @@ static_library("utility") {
         rebase_path(gypi_values.chrome_utility_safe_browsing_sources, ".", "..")
     deps += [ "//third_party/zlib" ]
   }
-
-  if (enable_pdf) {
-    deps += [ "//pdf" ]
-  }
 }
 
 if (is_mac) {