Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: build/config/BUILD.gn

Issue 1994713002: Make the dependency of enable_print_preview and enable_pdf explicit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/utility/BUILD.gn » ('j') | chrome/utility/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/BUILD.gn
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index 0ca8e18a5bb1ecef7d74ecac665bcab4a6d07a69..0b3b86df03a6479febe8b6e26634d7d0a9c87912 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -69,6 +69,8 @@ config("feature_flags") {
}
if (enable_pdf) {
defines += [ "ENABLE_PDF=1" ]
+ } else {
+ assert(!is_win, "set enable_pdf=true on Windows.")
Lei Zhang 2016/05/18 21:43:37 I'd prefer we remove this check, and put all the c
Wei Li 2016/05/19 17:13:30 Done.
}
if (enable_basic_printing || enable_print_preview) {
# Convenience define for ENABLE_BASIC_PRINTING || ENABLE_PRINT_PREVIEW.
@@ -81,6 +83,8 @@ config("feature_flags") {
# Enable printing with print preview.
# Can be defined without ENABLE_BASIC_PRINTING.
defines += [ "ENABLE_PRINT_PREVIEW=1" ]
+ assert(enable_pdf,
+ "Print preview depends on pdf module: set enable_pdf=true.")
}
}
if (enable_spellcheck) {
« no previous file with comments | « no previous file | chrome/utility/BUILD.gn » ('j') | chrome/utility/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698