|
|
Created:
4 years, 7 months ago by rmistry Modified:
4 years, 7 months ago Reviewers:
dogben CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/buildbot@ct-5-capture_archives Target Ref:
refs/heads/master Project:
skiabuildbot Visibility:
Public. |
DescriptionUse swarming in capture_skps and capture_skps_from_pdfs CT tasks.
Tested capture_skps with:
$ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local
$ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing
Verified that the above created 872 SKPs:
$ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l
872
Tested capture_skps_from_pdfs with:
$ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local
$ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing
Verified that the above created 979 PDFs:
$ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l
978
BUG=skia:5294
Committed: https://skia.googlesource.com/buildbot/+/d22b24489b8cd5026d598a279d832659bb8bc208
Patch Set 1 : Initial upload #Patch Set 2 : capture_skps.isolate #Patch Set 3 : Capture SKPs from PDFs #Patch Set 4 : Fix ValidateSKPs #Patch Set 5 : capture_skps_from_pdfs.isolate #Patch Set 6 : Rebase #Patch Set 7 : Rebase #
Total comments: 1
Patch Set 8 : Use new method in util.go #Patch Set 9 : Rebase #
Total comments: 8
Patch Set 10 : Address comments #
Depends on Patchset: Messages
Total messages: 29 (18 generated)
Description was changed from ========== Use swarming in capture_skps CT task Tested with: $ $ Verified that the above created x SKPs: BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ $ Verified that the above created x SKPs: Tested capture_skps_from_pdfs with: $ $ Verified that the above created x PDFs: BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ $ Verified that the above created x SKPs: Tested capture_skps_from_pdfs with: $ $ Verified that the above created x PDFs: BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ Verified that the above created x SKPs: Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ Verified that the above created x SKPs: Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry-test/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ==========
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ==========
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/100001
rmistry@google.com changed reviewers: + benjaminwagner@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/b...)
The CQ bit was checked by rmistry@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/120001
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created x SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created x PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 844 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ==========
Ready for review
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 844 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 844 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 979 BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 872 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 872 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 978 BUG=skia:5294 ==========
lgtm Only ignorable comments. https://codereview.chromium.org/1994663002/diff/120001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1994663002/diff/120001/ct/go/util/util.go#new... ct/go/util/util.go:289: // This splice will be used to run remove_invalid_skp.py on. s/splice/slice/, s/ on// https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go#new... ct/go/util/util.go:289: // This splice will be used to run remove_invalid_skp.py on. s/splice/slice/, s/ on// https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go#new... ct/go/util/util.go:294: return fmt.Errorf("Unable to read %s: %s", indexDirs, err) s/indexDirs/pathToSkps/ https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... File ct/go/worker_scripts/capture_skps/main.go (right): https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... ct/go/worker_scripts/capture_skps/main.go:94: // if err := gs.DownloadWorkerArtifacts(util.PAGESETS_DIR_NAME, *pagesetType, *workerNum); err != nil { nit: delete https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... ct/go/worker_scripts/capture_skps/main.go:162: index := archivesToIndex[decodedPageset.ArchiveDataFile] paranoid: check that archivesToIndex contains an entry for this archive.
https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go#new... ct/go/util/util.go:289: // This splice will be used to run remove_invalid_skp.py on. On 2016/05/19 16:48:41, Ben Wagner wrote: > s/splice/slice/, s/ on// Done. https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go#new... ct/go/util/util.go:294: return fmt.Errorf("Unable to read %s: %s", indexDirs, err) On 2016/05/19 16:48:41, Ben Wagner wrote: > s/indexDirs/pathToSkps/ Done. https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... File ct/go/worker_scripts/capture_skps/main.go (right): https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... ct/go/worker_scripts/capture_skps/main.go:94: // if err := gs.DownloadWorkerArtifacts(util.PAGESETS_DIR_NAME, *pagesetType, *workerNum); err != nil { On 2016/05/19 16:48:41, Ben Wagner wrote: > nit: delete Done. https://codereview.chromium.org/1994663002/diff/160001/ct/go/worker_scripts/c... ct/go/worker_scripts/capture_skps/main.go:162: index := archivesToIndex[decodedPageset.ArchiveDataFile] On 2016/05/19 16:48:41, Ben Wagner wrote: > paranoid: check that archivesToIndex contains an entry for this archive. Done.
lgtm Still LGTM.
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/180001
Message was sent while issue was closed.
Description was changed from ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 872 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 872 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 978 BUG=skia:5294 ========== to ========== Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 872 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 872 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 978 BUG=skia:5294 Committed: https://skia.googlesource.com/buildbot/+/d22b24489b8cd5026d598a279d832659bb8b... ==========
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as https://skia.googlesource.com/buildbot/+/d22b24489b8cd5026d598a279d832659bb8b... |