Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1994663002: Use swarming in capture_skps and capture_skps_from_pdfs CT tasks (Closed)

Created:
4 years, 7 months ago by rmistry
Modified:
4 years, 7 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@ct-5-capture_archives
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use swarming in capture_skps and capture_skps_from_pdfs CT tasks. Tested capture_skps with: $ go run go/worker_scripts/capture_skps/main.go --logtostderr --start_range=1 --num=10 --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=Dummy1k --chromium_build=try-1e224f6-f1036b2-rmistry-20160206122201-withpatch --run_id=testing Verified that the above created 872 SKPs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/skps/Dummy1k/try-1e224f6-f1036b2-rmistry-20160206122201-withpatch/*/*.skp | grep -v TOTAL | wc -l 872 Tested capture_skps_from_pdfs with: $ go run go/worker_scripts/capture_skps_from_pdfs/main.go --logtostderr --start_range=1 --num=10 --pageset_type=PDF1k --chromium_build=testing --run_id=testing --local $ go run go/master_scripts/capture_skps_on_workers/main.go --logtostderr --emails=”rmistry@google.com” --pageset_type=PDF1k --chromium_build=testing --run_id=testing Verified that the above created 979 PDFs: $ gsutil -m ls -l gs://cluster-telemetry/swarming/pdfs/PDF1k/testing/*/*.pdf | grep -v TOTAL | wc -l 978 BUG=skia:5294 Committed: https://skia.googlesource.com/buildbot/+/d22b24489b8cd5026d598a279d832659bb8bc208

Patch Set 1 : Initial upload #

Patch Set 2 : capture_skps.isolate #

Patch Set 3 : Capture SKPs from PDFs #

Patch Set 4 : Fix ValidateSKPs #

Patch Set 5 : capture_skps_from_pdfs.isolate #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Total comments: 1

Patch Set 8 : Use new method in util.go #

Patch Set 9 : Rebase #

Total comments: 8

Patch Set 10 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -165 lines) Patch
M ct/go/master_scripts/capture_skps_on_workers/main.go View 1 2 3 4 5 6 7 5 chunks +27 lines, -40 lines 0 comments Download
M ct/go/util/constants.go View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M ct/go/util/util.go View 1 2 3 4 5 6 7 8 9 2 chunks +40 lines, -38 lines 0 comments Download
M ct/go/worker_scripts/capture_skps/main.go View 1 2 3 4 5 6 7 8 9 8 chunks +21 lines, -64 lines 0 comments Download
M ct/go/worker_scripts/capture_skps_from_pdfs/main.go View 1 2 9 chunks +22 lines, -16 lines 0 comments Download
A + ct/isolates/capture_skps.isolate View 1 1 chunk +4 lines, -2 lines 0 comments Download
A + ct/isolates/capture_skps_from_pdfs.isolate View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/100001
4 years, 7 months ago (2016-05-18 17:57:49 UTC) #10
rmistry
4 years, 7 months ago (2016-05-18 17:58:17 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/3953)
4 years, 7 months ago (2016-05-18 18:04:12 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/120001
4 years, 7 months ago (2016-05-18 18:12:00 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 18:14:51 UTC) #19
rmistry
Ready for review
4 years, 7 months ago (2016-05-19 15:25:15 UTC) #21
dogben
lgtm Only ignorable comments. https://codereview.chromium.org/1994663002/diff/120001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1994663002/diff/120001/ct/go/util/util.go#newcode289 ct/go/util/util.go:289: // This splice will be ...
4 years, 7 months ago (2016-05-19 16:48:41 UTC) #23
rmistry
https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go File ct/go/util/util.go (right): https://codereview.chromium.org/1994663002/diff/160001/ct/go/util/util.go#newcode289 ct/go/util/util.go:289: // This splice will be used to run remove_invalid_skp.py ...
4 years, 7 months ago (2016-05-19 17:01:25 UTC) #24
dogben
lgtm Still LGTM.
4 years, 7 months ago (2016-05-19 17:07:18 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994663002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994663002/180001
4 years, 7 months ago (2016-05-19 17:19:18 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 17:22:16 UTC) #29
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as
https://skia.googlesource.com/buildbot/+/d22b24489b8cd5026d598a279d832659bb8b...

Powered by Google App Engine
This is Rietveld 408576698