ct/isolates/capture_skps.isolate - Issue 1994663002: Use swarming in capture_skps and capture_skps_from_pdfs CT tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ct/isolates/capture_skps.isolate

Issue 1994663002: Use swarming in capture_skps and capture_skps_from_pdfs CT tasks (Closed) Base URL: https://skia.googlesource.com/buildbot@ct-5-capture_archives

Patch Set: Address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ct/isolates/capture_skps.isolate

diff --git a/ct/isolates/create_pagesets.isolate b/ct/isolates/capture_skps.isolate

similarity index 74%

copy from ct/isolates/create_pagesets.isolate

copy to ct/isolates/capture_skps.isolate

index 8447766147539c0d2f17a83142c9c707dc06e593..9c847c9e20e45ac152e02f9d3c07ee231e327fe4 100644

--- a/ct/isolates/create_pagesets.isolate

+++ b/ct/isolates/capture_skps.isolate

@@ -10,14 +10,16 @@

['OS=="linux"', {

'variables': {

'files': [

- '../../../../../bin/create_pagesets',

+ '../../../../../bin/capture_skps',

'command': [

- '../../../../../bin/create_pagesets',

+ '../../../../../bin/capture_skps',

'-logtostderr',

'--start_range=<(START_RANGE)',

'--num=<(NUM)',

'--pageset_type=<(PAGESET_TYPE)',

+ '--chromium_build=<(CHROMIUM_BUILD)',

+ '--run_id=<(RUN_ID)'

}],

« no previous file with comments | « ct/go/worker_scripts/capture_skps_from_pdfs/main.go ('k') | ct/isolates/capture_skps_from_pdfs.isolate » ('j') | no next file with comments »