Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: tools/perf/page_sets/tough_path_rendering_cases.py

Issue 1994653004: telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-chalkboard-recording
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_path_rendering_cases.py
diff --git a/tools/perf/page_sets/tough_path_rendering_cases.py b/tools/perf/page_sets/tough_path_rendering_cases.py
index c565e7e61f29fa7639215e83fad655e8151789d8..4227fed45263f049bea6458a56cee5d2c55728da 100644
--- a/tools/perf/page_sets/tough_path_rendering_cases.py
+++ b/tools/perf/page_sets/tough_path_rendering_cases.py
@@ -15,10 +15,12 @@ class ToughPathRenderingCasesPage(page_module.Page):
class ChalkboardPage(page_module.Page):
def RunPageInteractions(self, action_runner):
+ action_runner.tab.WaitForDocumentReadyStateToBeComplete()
Stephen White 2016/05/19 15:26:41 Hmmm! Note to self: we should probably add this to
with action_runner.CreateInteraction('ClickStart'):
action_runner.EvaluateJavaScript(
'document.getElementById("StartButton").click()')
- action_runner.Wait(20)
+ action_runner.WaitForJavaScriptCondition(
+ 'document.getElementById("FinalTime").innerText != ""')
Stephen White 2016/05/19 15:26:41 It would be really cool to gather the actual value
Kimmo Kinnunen 2016/05/20 10:54:42 So would this be another "benchmark" in addition t
Stephen White 2016/05/20 13:25:12 I had assumed it could just be added to the existi
class ToughPathRenderingCasesPageSet(story.StorySet):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698