[Chromecast] Update the default value of use_gold for Cast builds.

[Chromecast] Update the default value of use_gold for Cast builds.

Chromecast builds require that target toolchains not use gold. Other
options do not work:
  1) toolchain_args are ignored when the toolchain is default, so
     setting use_gold explicitly for our target toolchains is infeasible.
  2) We want host toolchains to take the default value for use_gold, so
     overriding with a GN arg is infeasible.

Setting use_gold on a per-toolchain basis is ideal, but until the issue
in (1) is resolved, this will need to be our workaround.

BUG=NONE

Committed: https://crrev.com/2dcea1128cc5021fc1baef55fd78166397712817
Cr-Commit-Position: refs/heads/master@{#394872}

[slan, 2016-05-19 18:48:40]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 18:49:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994623004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994623004/1

[slan, 2016-05-19 18:50:13]

slan@chromium.org changed reviewers:
+ dpranke@chromium.org

[slan, 2016-05-19 18:50:13]

Chromecast needs to *not use* gold for our target toolchains, but *use gold* for
our host toolchains. This is the cleanest way to do it for now. PTAL!

[commit-bot: I haz the power, 2016-05-19 19:05:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 19:05:47]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[slan, 2016-05-19 19:16:47]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 19:17:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994623004/20001

[Dirk Pranke, 2016-05-19 19:33:38]

lgtm.

I've recently added several flags to make it easier to pass things like is_clang
to the host toolchain, but they're all chromeos-specific, e.g.,
cros_host_is_clang. There isn't a gold flag yet, though.

We could certainly add a host_is_gold flag, but if we can make the defaults
work, that's better than adding another variable.

Do you actually require gold on the host, or do you just want to use it? I
didn't think we actually required gold for anything ...

[slan, 2016-05-19 20:03:24]

The CQ bit was unchecked by slan@chromium.org

[slan, 2016-05-19 20:03:25]

The CQ bit was checked by slan@chromium.org

[commit-bot: I haz the power, 2016-05-19 20:03:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994623004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994623004/20001

[commit-bot: I haz the power, 2016-05-19 21:29:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 21:31:19]

Description was changed from

==========
[Chromecast] Update the default value of use_gold for Cast builds.

Chromecast builds require that target toolchains not use gold. Other
options do not work:
  1) toolchain_args are ignored when the toolchain is default, so
     setting use_gold explicitly for our target toolchains is infeasible.
  2) We want host toolchains to take the default value for use_gold, so
     overriding with a GN arg is infeasible.

Setting use_gold on a per-toolchain basis is ideal, but until the issue
in (1) is resolved, this will need to be our workaround.

BUG=NONE
==========

to

==========
[Chromecast] Update the default value of use_gold for Cast builds.

Chromecast builds require that target toolchains not use gold. Other
options do not work:
  1) toolchain_args are ignored when the toolchain is default, so
     setting use_gold explicitly for our target toolchains is infeasible.
  2) We want host toolchains to take the default value for use_gold, so
     overriding with a GN arg is infeasible.

Setting use_gold on a per-toolchain basis is ideal, but until the issue
in (1) is resolved, this will need to be our workaround.

BUG=NONE

Committed: https://crrev.com/2dcea1128cc5021fc1baef55fd78166397712817
Cr-Commit-Position: refs/heads/master@{#394872}
==========

[commit-bot: I haz the power, 2016-05-19 21:31:20]

Patchset 2 (id:??) landed as
https://crrev.com/2dcea1128cc5021fc1baef55fd78166397712817
Cr-Commit-Position: refs/heads/master@{#394872}