build/config/compiler/compiler.gni - Issue 1994623004: [Chromecast] Update the default value of use_gold for Cast builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/compiler.gni

Issue 1994623004: [Chromecast] Update the default value of use_gold for Cast builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Account for Cast on Android arm builds Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/compiler.gni

diff --git a/build/config/compiler/compiler.gni b/build/config/compiler/compiler.gni

index c2e56e4a5b311594e5f2f69d21bdc05ddc811f79..13109c28639bf43b10415136942e174fefad33b3 100644

--- a/build/config/compiler/compiler.gni

+++ b/build/config/compiler/compiler.gni

@@ -36,7 +36,8 @@ declare_args() {

declare_args() {

# Whether to use the gold linker from binutils instead of lld or bfd.

- use_gold = !use_lld &&

+ use_gold = !use_lld && !(is_chromecast && is_linux &&

+ (current_cpu == "arm" || current_cpu == "mipsel")) &&

((is_linux && (current_cpu == "x64" || current_cpu == "x86" ||

current_cpu == "arm")) ||

(is_android && (current_cpu == "x86" || current_cpu == "x64" ||

« no previous file with comments | « no previous file | no next file » | no next file with comments »