Handle use of constant constructors with default values.

Handle use of constant constructors with default values.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b3f8cd31a0192517ac73def58bed87f132dccdef

[Johnni Winther, 2016-05-19 12:42:41]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-05-19 16:46:45]

question below, otherwise lgtm

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:192:
evaluate(element.constant);
could this add more evaluations than what we had in the past? (I mean, can this
do something similar to the issue we discovered with deferred libraries a couple
weeks ago?)

[Johnni Winther, 2016-05-20 09:40:40]

Description was changed from

==========
Handle use of constant constructors with default values.
==========

to

==========
Handle use of constant constructors with default values.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b3f8cd31a0192517ac73def58bed87f132dccdef
==========

[Johnni Winther, 2016-05-20 09:40:41]

Committed patchset #2 (id:20001) manually as
b3f8cd31a0192517ac73def58bed87f132dccdef (presubmit successful).

[Johnni Winther, 2016-05-20 11:02:13]

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:192:
evaluate(element.constant);
On 2016/05/19 16:46:45, Siggi Cherem (dart-lang) wrote:
> could this add more evaluations than what we had in the past? (I mean, can
this
> do something similar to the issue we discovered with deferred libraries a
couple
> weeks ago?)

I'll put it behind a test for deserialization.

[Siggi Cherem (dart-lang), 2016-05-20 21:08:02]

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:192:
evaluate(element.constant);
On 2016/05/20 11:02:13, Johnni Winther wrote:
> On 2016/05/19 16:46:45, Siggi Cherem (dart-lang) wrote:
> > could this add more evaluations than what we had in the past? (I mean, can
> this
> > do something similar to the issue we discovered with deferred libraries a
> couple
> > weeks ago?)
> 
> I'll put it behind a test for deserialization.

Not sure I follow why it is needed then. I would expect that we should have no
semantic difference depending on where the element comes from.

Or are we guaranteed that evaluation already happened here for non-serialized
constants? Can we assert that the expression has already been evaluated in that
case?

Overall, I'd like to get to a point that, other than the loader, nothing else in
the compiler needs to know whether an element or constant came from sources or
deserialization.

[Johnni Winther, 2016-05-23 07:54:41]

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compile_time_constants.dart (right):

https://codereview.chromium.org/1994613004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compile_time_constants.dart:192:
evaluate(element.constant);
On 2016/05/20 21:08:02, Siggi Cherem (dart-lang) wrote:
> On 2016/05/20 11:02:13, Johnni Winther wrote:
> > On 2016/05/19 16:46:45, Siggi Cherem (dart-lang) wrote:
> > > could this add more evaluations than what we had in the past? (I mean, can
> > this
> > > do something similar to the issue we discovered with deferred libraries a
> > couple
> > > weeks ago?)
> > 
> > I'll put it behind a test for deserialization.
> 
> Not sure I follow why it is needed then. I would expect that we should have no
> semantic difference depending on where the element comes from.
> 
> Or are we guaranteed that evaluation already happened here for non-serialized
> constants? Can we assert that the expression has already been evaluated in
that
> case?

Yes. Will add an assertion.
 
> Overall, I'd like to get to a point that, other than the loader, nothing else
in
> the compiler needs to know whether an element or constant came from sources or
> deserialization.

Me too. I just want to tackle this issue on its own.