Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1994613004: Handle use of constant constructors with default values. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/elements/modelx.dart
diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart
index 3e148461f148d53196e35d7b8f19aaa6d21a513a..2381d64022b357abfcc46f8a1b83ca0e81f90309 100644
--- a/pkg/compiler/lib/src/elements/modelx.dart
+++ b/pkg/compiler/lib/src/elements/modelx.dart
@@ -256,6 +256,8 @@ class ErroneousElementX extends ElementX implements ErroneousElement {
bool get hasFunctionSignature => false;
+ bool get hasEffectiveTarget => true;
+
get effectiveTarget => this;
computeEffectiveTargetType(InterfaceType newType) => unsupported();
@@ -1391,6 +1393,11 @@ class VariableList implements DeclarationSite {
abstract class ConstantVariableMixin implements VariableElement {
ConstantExpression constantCache;
+ // TODO(johnniwinther): Update the on `constant = ...` when evaluation of
+ // constant expression can handle references to unanalyzed constant variables.
+ @override
+ bool get hasConstant => false;
+
ConstantExpression get constant {
if (isPatch) {
ConstantVariableMixin originVariable = origin;
@@ -2199,6 +2206,8 @@ abstract class ConstructorElementX extends FunctionElementX
DartType _effectiveTargetType;
bool _isEffectiveTargetMalformed;
+ bool get hasEffectiveTarget => effectiveTargetInternal != null;
+
void setEffectiveTarget(ConstructorElement target, DartType type,
{bool isMalformed: false}) {
assert(invariant(this, target != null,
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/resolution/resolution.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698