Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1994613002: Let dirty rect inflate after its unite with the affected area (Closed)

Created:
4 years, 7 months ago by xidachen
Modified:
4 years, 7 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let dirty rect inflate after its unite with the affected area In our previous CL: https://codereview.chromium.org/1983863002/, we let the dirty rect inflate by one pixel. However, this makes the dirty rect keeps growing. Instead, we should inflate the dirty rect after computing its intersection with the rect, which is the actual affected area. BUG=609820 TBR=junov@chromium.org Committed: https://crrev.com/0e9fa080a3438b3e4e8f2c525eaa43fff1393125 Cr-Commit-Position: refs/heads/master@{#394429}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994613002/1
4 years, 7 months ago (2016-05-18 13:48:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994613002/1
4 years, 7 months ago (2016-05-18 15:35:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 15:39:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0e9fa080a3438b3e4e8f2c525eaa43fff1393125 Cr-Commit-Position: refs/heads/master@{#394429}
4 years, 7 months ago (2016-05-18 15:41:03 UTC) #10
Justin Novosad
4 years, 7 months ago (2016-05-18 19:11:42 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1994613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/1994613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp:274:
m_dirtyRect.inflate(1);
what you meant to do is inflate "rect" before the union. As opposed to inflate
m_dirtyRect, which contains an accumulation

Powered by Google App Engine
This is Rietveld 408576698