third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 1994613002: Let dirty rect inflate after its unite with the affected area

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1994613002: Let dirty rect inflate after its unite with the affected area (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index 7555efbe2b9342af1215ffd32c5da3654fe2f907..5c8f2329b9f16f6332811ff126ce444d048ada06 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -269,9 +269,9 @@ void HTMLCanvasElement::didDraw(const FloatRect& rect)

clearCopiedImage();

if (layoutObject())

layoutObject()->setMayNeedPaintInvalidation();

+ m_dirtyRect.unite(rect);

if (m_context && m_context->is2d() && m_context->shouldAntialias() && page() && page()->deviceScaleFactor() > 1.0f)

m_dirtyRect.inflate(1);

Justin Novosad 2016/05/18 19:11:42 what you meant to do is inflate "rect" before the

- m_dirtyRect.unite(rect);

if (m_context && m_context->is2d() && hasImageBuffer())

buffer()->didDraw(rect);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »