Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1994503002: [turbofan] Turn common Guard operator into simplified TypeGuard. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn common Guard operator into simplified TypeGuard. The type guard should never be used after the effect/control linearization pass, so making it a simplified operator better expresses the intended use. Also this way none of the common operators actually has any dependency on the type system. Drive-by-fix: Properly print the type parameter to a TypeGuard operator. BUG=chromium:612142 R=jarin@chromium.org Committed: https://crrev.com/c5a71f029fb554c6a79a9226a99258c12751bd9b Cr-Commit-Position: refs/heads/master@{#36304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -81 lines) Patch
M src/compiler/common-operator.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/common-operator-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/common-operator-reducer.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M src/compiler/load-elimination.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/compiler/load-elimination.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-18 05:43:34 UTC) #1
Benedikt Meurer
Hey Jaro, Follow up cleanup to make sure no one misuses Guard nodes (or at ...
4 years, 7 months ago (2016-05-18 05:44:17 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-18 05:47:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994503002/1
4 years, 7 months ago (2016-05-18 05:49:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 06:19:19 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 06:19:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5a71f029fb554c6a79a9226a99258c12751bd9b
Cr-Commit-Position: refs/heads/master@{#36304}

Powered by Google App Engine
This is Rietveld 408576698