Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1994453002: DevTools: fix "edit breakpoint" message box in Sources panel (Closed)

Created:
4 years, 7 months ago by lushnikov
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix "edit breakpoint" message box in Sources panel BUG=612428 R=dgozman Committed: https://crrev.com/288d8e126950d385b049cdaa7298f9dad2dbb542 Cr-Commit-Position: refs/heads/master@{#394354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/sourcesPanel.css View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/sourcesView.css View 1 chunk +30 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1917863008 Patch 20001

Messages

Total messages: 11 (4 generated)
lushnikov
please, take a look!
4 years, 7 months ago (2016-05-18 01:54:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994453002/1
4 years, 7 months ago (2016-05-18 01:55:46 UTC) #3
dgozman
lgtm
4 years, 7 months ago (2016-05-18 03:04:11 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/223654)
4 years, 7 months ago (2016-05-18 05:54:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994453002/1
4 years, 7 months ago (2016-05-18 07:03:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 07:58:38 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 08:00:16 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/288d8e126950d385b049cdaa7298f9dad2dbb542
Cr-Commit-Position: refs/heads/master@{#394354}

Powered by Google App Engine
This is Rietveld 408576698