Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1994443003:
[Layout API] Use FrameView::layoutViewItem() in WebPluginContainerImpl.cpp (Closed)
|
Created:
4 years, 7 months ago by pilgrim_google Modified:
4 years, 5 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, dgrogan, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Layout API] Use FrameView::layoutViewItem() in WebPluginContainerImpl.cpp
There are several references to layoutView() which can be replaced
1-1 with layoutViewItem(). I had to add a localToAbsoluteQuad() method
to LayoutItem.
BUG=499321
Committed: https://crrev.com/272b716ad966838ec463cdfc6693ee38083f7e1c
Cr-Commit-Position: refs/heads/master@{#405653}
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
pilgrim@chromium.org changed reviewers: + eae@chromium.org, jsbell@chromium.org
The CQ bit was checked by pilgrim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994443003/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by eae@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1994443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1994443003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by pilgrim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
pilgrim@chromium.org changed reviewers: + tkent@chromium.org
pilgrim@chromium.org changed required reviewers: + tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [Layout API] Use FrameView::layoutViewItem() in WebPluginContainerImpl.cpp There are several references to layoutView() which can be replaced 1-1 with layoutViewItem(). I had to add a localToAbsoluteQuad() method to LayoutItem. BUG=499321 ========== to ========== [Layout API] Use FrameView::layoutViewItem() in WebPluginContainerImpl.cpp There are several references to layoutView() which can be replaced 1-1 with layoutViewItem(). I had to add a localToAbsoluteQuad() method to LayoutItem. BUG=499321 Committed: https://crrev.com/272b716ad966838ec463cdfc6693ee38083f7e1c Cr-Commit-Position: refs/heads/master@{#405653} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/272b716ad966838ec463cdfc6693ee38083f7e1c Cr-Commit-Position: refs/heads/master@{#405653} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
