Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 1994443003: [Layout API] Use FrameView::layoutViewItem() in WebPluginContainerImpl.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LayoutItem.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
index d1f412fec1a9c16b95a395df08b8b8dd374ae201..351bbbe9de40ec0b7b218ee7c872f49ec70e84db 100644
--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
@@ -910,7 +910,7 @@ void WebPluginContainerImpl::computeClipRectsForPlugin(
windowRect = frameRect();
// Map up to the root frame.
LayoutRect layoutWindowRect =
- LayoutRect(m_element->document().view()->layoutView()->localToAbsoluteQuad(FloatQuad(FloatRect(frameRect())), TraverseDocumentBoundaries).boundingBox());
+ LayoutRect(m_element->document().view()->layoutViewItem().localToAbsoluteQuad(FloatQuad(FloatRect(frameRect())), TraverseDocumentBoundaries).boundingBox());
// Finally, adjust for scrolling of the root frame, which the above does not take into account.
layoutWindowRect.moveBy(-rootView->viewRect().location());
windowRect = pixelSnappedIntRect(layoutWindowRect);
@@ -933,7 +933,7 @@ void WebPluginContainerImpl::calculateGeometry(IntRect& windowRect, IntRect& cli
// document().layoutView() can be null when we receive messages from the
// plugins while we are destroying a frame.
// FIXME: Can we just check m_element->document().isActive() ?
- if (m_element->layoutObject()->document().layoutView()) {
+ if (!m_element->layoutObject()->document().layoutViewItem().isNull()) {
// Take our element and get the clip rect from the enclosing layer and
// frame view.
computeClipRectsForPlugin(m_element, windowRect, clipRect, unobscuredRect);
« no previous file with comments | « third_party/WebKit/Source/core/layout/api/LayoutItem.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698