Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1994243002: Dangling comment reference cleanup in analyzer. (Closed)

Created:
4 years, 7 months ago by pquitslund
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Dangling comment reference cleanup in analyzer. First pass with the new `comment_reference` lint. BUG= R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c07b21d03bc0cdd5d1e39e6f2bf7672b9ac048d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -26 lines) Patch
M pkg/analyzer/lib/analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/dart/ast/ast.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/embedder.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/ast/token.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 5 chunks +6 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong/checker.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 7 months ago (2016-05-19 16:37:37 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-19 17:01:16 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as c07b21d03bc0cdd5d1e39e6f2bf7672b9ac048d7 (presubmit successful).
4 years, 7 months ago (2016-05-19 17:24:59 UTC) #5
Brian Wilkerson
4 years, 7 months ago (2016-05-20 14:11:22 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698