Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: pkg/analyzer/lib/source/sdk_ext.dart

Issue 1994243002: Dangling comment reference cleanup in analyzer. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/lib/source/embedder.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.source.sdk_ext; 5 library analyzer.source.sdk_ext;
6 6
7 import 'dart:convert'; 7 import 'dart:convert';
8 import 'dart:core' hide Resource; 8 import 'dart:core' hide Resource;
9 9
10 import 'package:analyzer/file_system/file_system.dart'; 10 import 'package:analyzer/file_system/file_system.dart';
11 import 'package:analyzer/source/package_map_provider.dart'
12 show PackageMapProvider;
11 import 'package:analyzer/src/generated/java_io.dart' show JavaFile; 13 import 'package:analyzer/src/generated/java_io.dart' show JavaFile;
12 import 'package:analyzer/src/generated/source.dart'; 14 import 'package:analyzer/src/generated/source.dart';
13 import 'package:analyzer/src/generated/source_io.dart' show FileBasedSource; 15 import 'package:analyzer/src/generated/source_io.dart' show FileBasedSource;
14 import 'package:path/path.dart' as pathos; 16 import 'package:path/path.dart' as pathos;
15 17
16 /// Given a packageMap (see [PackageMapProvider]), check in each package's lib 18 /// Given a packageMap (see [PackageMapProvider]), check in each package's lib
17 /// directory for the existence of a `_sdkext` file. This file must contain a 19 /// directory for the existence of a `_sdkext` file. This file must contain a
18 /// JSON encoded map. Each key in the map is a `dart:` library name. Each value 20 /// JSON encoded map. Each key in the map is a `dart:` library name. Each value
19 /// is a path (relative to the directory containing `_sdkext`) to a dart script 21 /// is a path (relative to the directory containing `_sdkext`) to a dart script
20 /// for the given library. For example: 22 /// for the given library. For example:
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 /// Resolve a 'part' statement inside an sdk extension. 176 /// Resolve a 'part' statement inside an sdk extension.
175 Source _resolvePart(Uri libraryEntry, String partPath, Uri importUri) { 177 Source _resolvePart(Uri libraryEntry, String partPath, Uri importUri) {
176 // Library part. 178 // Library part.
177 var directory = pathos.dirname(libraryEntry.path); 179 var directory = pathos.dirname(libraryEntry.path);
178 var partUri = new Uri.file(pathos.join(directory, partPath)); 180 var partUri = new Uri.file(pathos.join(directory, partPath));
179 assert(partUri.isAbsolute); 181 assert(partUri.isAbsolute);
180 JavaFile javaFile = new JavaFile.fromUri(partUri); 182 JavaFile javaFile = new JavaFile.fromUri(partUri);
181 return new FileBasedSource(javaFile, importUri); 183 return new FileBasedSource(javaFile, importUri);
182 } 184 }
183 } 185 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/source/embedder.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698