Fix "unused variable" warnings.

Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none

Committed: https://crrev.com/3bc27f8eb9e051454cdeadbcda8000683eccca1a
Cr-Commit-Position: refs/heads/master@{#395003}

[Peter Kasting, 2016-05-19 05:27:22]

pkasting@chromium.org changed reviewers:
+ sievers@chromium.org

[timvolodine, 2016-05-19 14:01:43]

timvolodine@chromium.org changed reviewers:
+ timvolodine@chromium.org

[timvolodine, 2016-05-19 14:01:44]

https://codereview.chromium.org/1994013002/diff/20001/content/browser/device_...
File content/browser/device_sensors/data_fetcher_shared_memory.h (right):

https://codereview.chromium.org/1994013002/diff/20001/content/browser/device_...
content/browser/device_sensors/data_fetcher_shared_memory.h:55:
DeviceOrientationHardwareBuffer* orientation_absolute_buffer_ = nullptr;
yeah sorry, we actually need it for windows as well (i've just landed a patch),
so maybe just keep the "!defined(OS_ANDROID)" above..

[no sievers, 2016-05-19 17:58:00]

lgtm

https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
File content/browser/ppapi_plugin_process_host.cc (right):

https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
content/browser/ppapi_plugin_process_host.cc:67: #elif defined(OS_POSIX)
nit: can you put the OS_POSIX outside of the MAC/ANDROID check?

#elif defined(OS_POSIX)
#if defined(OS_MACOSX) || defined(OS_ANDROID)
  : ipc_fd_(host->TakeClientFileDescriptor()) {
#else
  : ipc_fd_(host->TakeClientFileDescriptor()), is_broker_(is_broker){
#endif
#endif  // OS_POSIX

[Peter Kasting, 2016-05-19 18:14:46]

https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
File content/browser/ppapi_plugin_process_host.cc (right):

https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
content/browser/ppapi_plugin_process_host.cc:67: #elif defined(OS_POSIX)
On 2016/05/19 17:58:00, sievers wrote:
> nit: can you put the OS_POSIX outside of the MAC/ANDROID check?
> 
> #elif defined(OS_POSIX)
> #if defined(OS_MACOSX) || defined(OS_ANDROID)
>   : ipc_fd_(host->TakeClientFileDescriptor()) {
> #else
>   : ipc_fd_(host->TakeClientFileDescriptor()), is_broker_(is_broker){
> #endif
> #endif  // OS_POSIX

We would still need another #else:

#if defined(OS_WIN)
      : info_(info), is_broker_(is_broker) {
#elif defined(OS_POSIX)
#if defined(OS_MACOSX) || defined(OS_ANDROID)
      : ipc_fd_(host->TakeClientFileDescriptor()) {
#else
      : ipc_fd_(host->TakeClientFileDescriptor()), is_broker_(is_broker){
#endif
#else
  {
#endif

I did this originally, but I thought it was actually harder to read than the
current method (I get easily confused by nested #ifdefs).

I don't feel violently.  Do you still think this would be better given the full
formulation above?

[no sievers, 2016-05-19 18:17:04]

On 2016/05/19 18:14:46, Peter Kasting wrote:
>
https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
> File content/browser/ppapi_plugin_process_host.cc (right):
> 
>
https://codereview.chromium.org/1994013002/diff/20001/content/browser/ppapi_p...
> content/browser/ppapi_plugin_process_host.cc:67: #elif defined(OS_POSIX)
> On 2016/05/19 17:58:00, sievers wrote:
> > nit: can you put the OS_POSIX outside of the MAC/ANDROID check?
> > 
> > #elif defined(OS_POSIX)
> > #if defined(OS_MACOSX) || defined(OS_ANDROID)
> >   : ipc_fd_(host->TakeClientFileDescriptor()) {
> > #else
> >   : ipc_fd_(host->TakeClientFileDescriptor()), is_broker_(is_broker){
> > #endif
> > #endif  // OS_POSIX
> 
> We would still need another #else:
> 
> #if defined(OS_WIN)
>       : info_(info), is_broker_(is_broker) {
> #elif defined(OS_POSIX)
> #if defined(OS_MACOSX) || defined(OS_ANDROID)
>       : ipc_fd_(host->TakeClientFileDescriptor()) {
> #else
>       : ipc_fd_(host->TakeClientFileDescriptor()), is_broker_(is_broker){
> #endif
> #else
>   {
> #endif
> 
> I did this originally, but I thought it was actually harder to read than the
> current method (I get easily confused by nested #ifdefs).
> 
> I don't feel violently.  Do you still think this would be better given the
full
> formulation above?

nope that's fine. I believe you that either way it's a bit hard to read :)

[Peter Kasting, 2016-05-20 02:57:36]

https://codereview.chromium.org/1994013002/diff/20001/content/browser/device_...
File content/browser/device_sensors/data_fetcher_shared_memory.h (right):

https://codereview.chromium.org/1994013002/diff/20001/content/browser/device_...
content/browser/device_sensors/data_fetcher_shared_memory.h:55:
DeviceOrientationHardwareBuffer* orientation_absolute_buffer_ = nullptr;
On 2016/05/19 14:01:44, timvolodine wrote:
> yeah sorry, we actually need it for windows as well (i've just landed a
patch),
> so maybe just keep the "!defined(OS_ANDROID)" above..

I think that still has problems on platforms outside of (linux, mac, win), but
fixed in another way.

[Peter Kasting, 2016-05-20 02:57:44]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-05-20 02:57:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1994013002/#ps40001
(title: "Sync to latest behavior")

[commit-bot: I haz the power, 2016-05-20 02:58:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1994013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1994013002/40001

[commit-bot: I haz the power, 2016-05-20 04:50:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-20 04:52:01]

Description was changed from

==========
Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none
==========

to

==========
Fix "unused variable" warnings.

These were exposed by changing DISALLOW_COPY_AND_ASSIGN to use "= delete", and
must be fixed before that change can land.

See https://codereview.chromium.org/1981053002/ for the full CL.

BUG=447156
TEST=none

Committed: https://crrev.com/3bc27f8eb9e051454cdeadbcda8000683eccca1a
Cr-Commit-Position: refs/heads/master@{#395003}
==========

[commit-bot: I haz the power, 2016-05-20 04:52:03]

Patchset 3 (id:??) landed as
https://crrev.com/3bc27f8eb9e051454cdeadbcda8000683eccca1a
Cr-Commit-Position: refs/heads/master@{#395003}