Issue 1993983002: EDK: Add Core::GetRights().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1993983002: EDK: Add Core::GetRights(). (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Add Core::GetRights(). Don't actually plumb it out yet. I'll do that separately. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3d068bd1cab17bd3a8c442f101b5d08f7decf165

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -3 lines)			Patch
M	mojo/edk/system/core.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/edk/system/core.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	mojo/edk/system/core_test_base.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	mojo/edk/system/core_test_base.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	mojo/edk/system/core_unittest.cc	View	8 chunks	+57 lines, -3 lines	0 comments	Download

Dependent Patchsets:

Issue 1993283002 Patch 1

Issue 1993283002 Patch 20001

Issue 1993283002 Patch 40001

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 7 months ago (2016-05-19 20:04:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d068bd1cab17bd3a8c442f101b5d08f7decf165 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages