Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993283002: Add thunks for MojoGetRights(), etc. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work795_core_get_rights
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add thunks for MojoGetRights(), etc. I.e., this makes MojoGetRights() to apps. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e5ace236821d8810ec5f07f92299e3f4b8628d0e

Patch Set 1 #

Patch Set 2 : duh #

Patch Set 3 : I'm an idiot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -57 lines) Patch
M mojo/edk/embedder/entrypoints.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 1 2 8 chunks +35 lines, -16 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 23 chunks +35 lines, -21 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 18 chunks +54 lines, -20 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 6 chunks +49 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.c View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 5 chunks +44 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1993983002 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/1993983002/.
4 years, 7 months ago (2016-05-19 17:56:50 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-19 21:22:22 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-19 21:54:54 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e5ace236821d8810ec5f07f92299e3f4b8628d0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698