Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993953003: Update Timing2 to PaintTiming in comments. (Closed)

Created:
4 years, 7 months ago by Bryan McQuade
Modified:
4 years, 7 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Timing2 to PaintTiming in comments. BUG=611740 Committed: https://crrev.com/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b Cr-Commit-Position: refs/heads/master@{#395084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bryan McQuade
PTAL. This change just updates a few comments - no implementation changes.
4 years, 7 months ago (2016-05-19 17:54:30 UTC) #2
Charlie Harrison
lgtm
4 years, 7 months ago (2016-05-19 18:24:48 UTC) #3
rkaplow
lgtm
4 years, 7 months ago (2016-05-19 21:34:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993953003/1
4 years, 7 months ago (2016-05-20 15:35:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 16:11:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 16:14:05 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d930e1d05ae91d37b3ca5fb3fce4f0d3b13e208b
Cr-Commit-Position: refs/heads/master@{#395084}

Powered by Google App Engine
This is Rietveld 408576698