Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 1993953003: Update Timing2 to PaintTiming in comments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index ed9428b122096dd3382552eb2ea0eeeade788bad..12a37cd7c1a8496ec02cc4c55c15bd7207d701e0 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -193,8 +193,9 @@ void AbortsPageLoadMetricsObserver::OnComplete(
// If we have a committed load but |timing.IsEmpty()|, then this load was not
// tracked by the renderer. In this case, it is not possible to know whether
// the abort signals came before the page painted. Additionally, for
- // consistency with PageLoad.Timing2 metrics, we ignore non-render-tracked
- // loads when tracking aborts after commit.
+ // consistency with PageLoad.(Document|Paint|Parse)Timing metrics recorded by
+ // the CorePageLoadMetricsObserver, we ignore non-render-tracked loads when
+ // tracking aborts after commit.
if (timing.IsEmpty())
return;
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698