[Offline pages] Adding expiration capability to OfflinePageModel

components/offline_pages/offline_page_metadata_store_impl.cc

Index: components/offline_pages/offline_page_metadata_store_impl.cc
diff --git a/components/offline_pages/offline_page_metadata_store_impl.cc b/components/offline_pages/offline_page_metadata_store_impl.cc
index ead3fbe3e0369d187c1c300f0e9991384fae3781..247cd4e9d364512fcd620ba487c493425a45902d 100644
--- a/components/offline_pages/offline_page_metadata_store_impl.cc
+++ b/components/offline_pages/offline_page_metadata_store_impl.cc
@@ -59,6 +59,7 @@ void OfflinePageItemToEntry(const OfflinePageItem& item,
       static_cast<::offline_pages::OfflinePageEntry_Flags>(item.flags));
   item_proto->set_client_id_name_space(item.client_id.name_space);
   item_proto->set_client_id(item.client_id.id);
+  item_proto->set_expiration_time(item.expiration_time.ToInternalValue());
 }
 
 bool OfflinePageItemFromEntry(const offline_pages::OfflinePageEntry& item_proto,
@@ -97,6 +98,10 @@ bool OfflinePageItemFromEntry(const offline_pages::OfflinePageEntry& item_proto,
   }
   item->client_id.name_space = item_proto.client_id_name_space();
   item->client_id.id = item_proto.client_id();
+  if (item_proto.has_expiration_time()) {

[bburns, 2016/05/20 18:23:27]

remove curly braces for one line ifs ?

[fgorski, 2016/05/20 20:54:53]

notice the if content does not fit in a single line, hence no.

+    item->expiration_time =
+        base::Time::FromInternalValue(item_proto.expiration_time());
+  }
 
   return true;
 }