[Offline pages] Adding expiration capability to OfflinePageModel

components/offline_pages/offline_page_item.cc

Index: components/offline_pages/offline_page_item.cc
diff --git a/components/offline_pages/offline_page_item.cc b/components/offline_pages/offline_page_item.cc
index 98d514473d79f7e05fdfed13647df0023ace522b..19d1de12cbd2038d40178b863bf7562e2eda5610 100644
--- a/components/offline_pages/offline_page_item.cc
+++ b/components/offline_pages/offline_page_item.cc
@@ -69,4 +69,8 @@ GURL OfflinePageItem::GetOfflineURL() const {
   return net::FilePathToFileURL(file_path);
 }
 
+bool OfflinePageItem::IsExpired() const {

[romax, 2016/05/20 19:05:00]

seems like when you've set a value for expiration_time, it would be expired...
So I don't know why comparing the values here. And why not use last_access_time?

[fgorski, 2016/05/20 20:54:53]

first: It is easier to compare it against creaiton_time
second: last_access_time is commonly updated. Race condition on the update would
cause trouble.

+  return creation_time < expiration_time;
+}
+
 }  // namespace offline_pages