[Offline pages] Adding expiration capability to OfflinePageModel

components/offline_pages/offline_page_item.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_item.h"
 
 #include "components/offline_pages/proto/offline_pages.pb.h"
 #include "net/base/filename_util.h"
 
 namespace offline_pages {
@@ skipping 51 matching lines @@
 
 OfflinePageItem::OfflinePageItem(const OfflinePageItem& other) = default;
 
 OfflinePageItem::~OfflinePageItem() {
 }
 
 GURL OfflinePageItem::GetOfflineURL() const {
   return net::FilePathToFileURL(file_path);
 }
 
+bool OfflinePageItem::IsExpired() const {

[romax, 2016/05/20 19:05:00]

seems like when you've set a value for expiration_time, it would be expired...
So I don't know why comparing the values here. And why not use last_access_time?

[fgorski, 2016/05/20 20:54:53]

first: It is easier to compare it against creaiton_time
second: last_access_time is commonly updated. Race condition on the update would
cause trouble.

+  return creation_time < expiration_time;
+}
+
 }  // namespace offline_pages