chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java - Issue 1993873003: deprecate notificationId for downloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java

Issue 1993873003: deprecate notificationId for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java

index f02d7bceaa0cd7b0e50dc0f65faea10109f774b1..db703d236da11355eaa9c58c2ff51f2492a1e909 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java

@@ -102,7 +102,6 @@ public class DownloadSharedPreferenceEntry {

DownloadInfo info = new DownloadInfo.Builder()

.setDownloadGuid(downloadGuid)

.setFileName(fileName)

- .setNotificationId(notificationId)

.setIsResumable(isResumable)

.build();

return new DownloadItem(false, info);