Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3695)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java

Issue 1993873003: deprecate notificationId for downloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
index 939a139985bbdd36e995f16035dbb479664fe4d1..f4bd05e4aeadeade8cb7513dd1033fa7db7a3327 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
@@ -15,9 +15,12 @@ public interface DownloadNotifier {
/**
* Add a download successful notification.
* @param downloadInfo info about the successful download.
+ * @param systemDownloadId The system download ID assigned to the download.
+ * @param canResolve Whether the download can be resolved to any activity.
* @param intent Intent to launch when clicking the download notification.
*/
- void notifyDownloadSuccessful(DownloadInfo downloadInfo, Intent intent);
+ void notifyDownloadSuccessful(DownloadInfo downloadInfo, long systemDownloadId,
+ boolean canResolve, Intent intent);
/**
* Add a download failed notification.
@@ -45,10 +48,9 @@ public interface DownloadNotifier {
/**
* Cancel the notification for a download.
- * @param notificationId The notification ID of the cancelled download.
* @param downloadGuid The GUID of the cancelled download.
*/
- void cancelNotification(int notificationId, String downloadGuid);
+ void notifyDownloadCanceled(String downloadGuid);
/**
* Called to resume all the pending download entries in SharedPreferences.

Powered by Google App Engine
This is Rietveld 408576698