Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1993743004: Add ApplicationImplBase::Bind(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add ApplicationImplBase::Bind(). (And make the constructor not take an Application request.) This is to allow implementations to be instantiated before the message/run loop. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/21a4f27fb68ddfa590f5d34b0543cf56357d1a63

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M mojo/public/cpp/application/application_impl_base.h View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/cpp/application/lib/application_impl_base.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/ui/content_viewer_app.cc View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-18 19:24:54 UTC) #1
vardhan
lgtm https://codereview.chromium.org/1993743004/diff/1/mojo/ui/content_viewer_app.cc File mojo/ui/content_viewer_app.cc (right): https://codereview.chromium.org/1993743004/diff/1/mojo/ui/content_viewer_app.cc#newcode68 mojo/ui/content_viewer_app.cc:68: // TODO(vtl): This is leaky, since |ApplicationImpl| doesn't ...
4 years, 7 months ago (2016-05-19 02:39:36 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-19 16:53:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21a4f27fb68ddfa590f5d34b0543cf56357d1a63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698