Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/ui/content_viewer_app.cc

Issue 1993743004: Add ApplicationImplBase::Bind(). (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/cpp/application/lib/application_impl_base.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/ui/content_viewer_app.cc
diff --git a/mojo/ui/content_viewer_app.cc b/mojo/ui/content_viewer_app.cc
index edc5ad107481f28b0dcbfad1f8183f9b1f91adb5..0ede5d2ecbc7b62a3d8aaf20b2bc76781d98b50f 100644
--- a/mojo/ui/content_viewer_app.cc
+++ b/mojo/ui/content_viewer_app.cc
@@ -64,8 +64,11 @@ void ContentViewerApp::StartViewer(
mojo::InterfaceRequest<mojo::Application> application_request,
mojo::URLResponsePtr response) {
ViewProviderApp* app = LoadContent(content_handler_url, response.Pass());
- if (app)
+ if (app) {
+ // TODO(vtl): This is leaky, since |ApplicationImpl| doesn't own itself.
vardhan 2016/05/19 02:39:36 cc jeffbrown?
+ // (Also, who owns |*app|?)
new mojo::ApplicationImpl(app, application_request.Pass());
+ }
}
} // namespace ui
« no previous file with comments | « mojo/public/cpp/application/lib/application_impl_base.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698