Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1993633002: Version 5.1.281.41 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by Toon Verwaest
Modified:
4 years, 7 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.1
Target Ref:
refs/pending/branch-heads/5.1
Project:
v8
Visibility:
Public.

Description

Version 5.1.281.41 (cherry-pick) Convert primitive receivers for API property callbacks Don't compile code for LoadICs if the receiver is primitive Interceptors expect the receiver to always be an JSReceiver. BUG=chromium:609134 LOG=N R=hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/bf95fd960eaa78da2edfe5d7ba26169cb1c0433a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -16 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/accessors.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ic/ic.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M src/objects.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/objects.cc View 7 chunks +54 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
4 years, 7 months ago (2016-05-18 08:14:53 UTC) #1
Michael Hablich
On 2016/05/18 08:14:53, Toon Verwaest wrote: lgtm
4 years, 7 months ago (2016-05-18 08:15:26 UTC) #2
Toon Verwaest
4 years, 7 months ago (2016-05-18 08:19:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf95fd960eaa78da2edfe5d7ba26169cb1c0433a.

Powered by Google App Engine
This is Rietveld 408576698