Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1993403002: GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not GrContext) (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GrSWMaskHelper and GrSoftwarePathRenderer only need the textureProvider (not GrContext) This is split out of: https://codereview.chromium.org/1988923002/ (Declassify GrClipMaskManager and Remove GrRenderTarget and GrDrawTarget from GrPipelineBuilder) BUG=skia: Committed: https://skia.googlesource.com/skia/+/0152d731e0be311fda29467086d2c83629601aa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -42 lines) Patch
M src/gpu/GrClipMaskManager.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 5 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 4 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
robertphillips
4 years, 7 months ago (2016-05-19 21:57:55 UTC) #1
robertphillips
4 years, 7 months ago (2016-05-19 21:58:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993403002/1
4 years, 7 months ago (2016-05-19 21:58:24 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 22:19:39 UTC) #8
bsalomon
lgtm
4 years, 7 months ago (2016-05-19 22:26:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993403002/1
4 years, 7 months ago (2016-05-20 13:37:45 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 13:38:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0152d731e0be311fda29467086d2c83629601aa1

Powered by Google App Engine
This is Rietveld 408576698