Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1993313002: [Mac][Material Design] Show light default favicon in Incognito mode. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Show light default favicon in Incognito mode. The original MD bookmarks cl did not update the default bookmark favicon to Material Design. R=avi@chromium.org BUG=613128 Committed: https://crrev.com/f108ab948c53674428f0a5a518a48a2a6d6b5198 Cr-Commit-Position: refs/heads/master@{#394851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 3 chunks +16 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-19 19:11:23 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-19 19:12:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993313002/1
4 years, 7 months ago (2016-05-19 19:19:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 20:45:17 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:46:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f108ab948c53674428f0a5a518a48a2a6d6b5198
Cr-Commit-Position: refs/heads/master@{#394851}

Powered by Google App Engine
This is Rietveld 408576698