Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 1993313002: [Mac][Material Design] Show light default favicon in Incognito mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" 5 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #import "base/mac/bundle_locations.h" 9 #import "base/mac/bundle_locations.h"
10 #import "base/mac/foundation_util.h" 10 #import "base/mac/foundation_util.h"
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 folderTarget_.reset( 308 folderTarget_.reset(
309 [[BookmarkFolderTarget alloc] initWithController:self 309 [[BookmarkFolderTarget alloc] initWithController:self
310 profile:browser_->profile()]); 310 profile:browser_->profile()]);
311 311
312 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 312 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
313 folderImage_.reset( 313 folderImage_.reset(
314 rb.GetNativeImageNamed(IDR_BOOKMARK_BAR_FOLDER).CopyNSImage()); 314 rb.GetNativeImageNamed(IDR_BOOKMARK_BAR_FOLDER).CopyNSImage());
315 if (ui::MaterialDesignController::IsModeMaterial()) { 315 if (ui::MaterialDesignController::IsModeMaterial()) {
316 folderImageWhite_.reset( 316 folderImageWhite_.reset(
317 rb.GetNativeImageNamed(IDR_BOOKMARK_BAR_FOLDER_WHITE).CopyNSImage()); 317 rb.GetNativeImageNamed(IDR_BOOKMARK_BAR_FOLDER_WHITE).CopyNSImage());
318
319 const int kIconSize = 16;
320 defaultImage_.reset([NSImageFromImageSkia(
321 gfx::CreateVectorIcon(gfx::VectorIconId::LOCATION_BAR_HTTP,
322 kIconSize,
323 gfx::kChromeIconGrey)) retain]);
324 defaultImageIncognito_.reset([NSImageFromImageSkia(
325 gfx::CreateVectorIcon(gfx::VectorIconId::LOCATION_BAR_HTTP,
326 kIconSize,
327 SkColorSetA(SK_ColorWHITE, 0xCC))) retain]);
328 } else {
329 defaultImage_.reset(
330 rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON).CopyNSImage());
331 defaultImageIncognito_.reset([defaultImage_.get() retain]);
318 } 332 }
319 defaultImage_.reset(
320 rb.GetNativeImageNamed(IDR_DEFAULT_FAVICON).CopyNSImage());
321 333
322 innerContentAnimationsEnabled_ = YES; 334 innerContentAnimationsEnabled_ = YES;
323 stateAnimationsEnabled_ = YES; 335 stateAnimationsEnabled_ = YES;
324 336
325 // Register for theme changes, bookmark button pulsing, ... 337 // Register for theme changes, bookmark button pulsing, ...
326 NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter]; 338 NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
327 [defaultCenter addObserver:self 339 [defaultCenter addObserver:self
328 selector:@selector(themeDidChangeNotification:) 340 selector:@selector(themeDidChangeNotification:)
329 name:kBrowserThemeDidChangeNotification 341 name:kBrowserThemeDidChangeNotification
330 object:nil]; 342 object:nil];
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 // If we ever need any other animation cases, code would go here. 711 // If we ever need any other animation cases, code would go here.
700 } 712 }
701 713
702 // In general, only show the divider when it's in the normal showing state. 714 // In general, only show the divider when it's in the normal showing state.
703 return [self isInState:BookmarkBar::SHOW] ? 0 : 1; 715 return [self isInState:BookmarkBar::SHOW] ? 0 : 1;
704 } 716 }
705 717
706 - (NSImage*)faviconForNode:(const BookmarkNode*)node 718 - (NSImage*)faviconForNode:(const BookmarkNode*)node
707 forADarkTheme:(BOOL)forADarkTheme { 719 forADarkTheme:(BOOL)forADarkTheme {
708 if (!node) 720 if (!node)
709 return defaultImage_; 721 return forADarkTheme ? defaultImageIncognito_ : defaultImage_;
710 722
711 if (forADarkTheme && ui::MaterialDesignController::IsModeMaterial()) { 723 if (forADarkTheme && ui::MaterialDesignController::IsModeMaterial()) {
712 if (node == managedBookmarkService_->managed_node()) { 724 if (node == managedBookmarkService_->managed_node()) {
713 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 725 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
714 return rb.GetNativeImageNamed( 726 return rb.GetNativeImageNamed(
715 IDR_BOOKMARK_BAR_FOLDER_MANAGED_WHITE).ToNSImage(); 727 IDR_BOOKMARK_BAR_FOLDER_MANAGED_WHITE).ToNSImage();
716 } 728 }
717 729
718 if (node == managedBookmarkService_->supervised_node()) { 730 if (node == managedBookmarkService_->supervised_node()) {
719 ResourceBundle& rb = ResourceBundle::GetSharedInstance(); 731 ResourceBundle& rb = ResourceBundle::GetSharedInstance();
(...skipping 19 matching lines...) Expand all
739 } 751 }
740 752
741 if (node->is_folder()) 753 if (node->is_folder())
742 return folderImage_; 754 return folderImage_;
743 } 755 }
744 756
745 const gfx::Image& favicon = bookmarkModel_->GetFavicon(node); 757 const gfx::Image& favicon = bookmarkModel_->GetFavicon(node);
746 if (!favicon.IsEmpty()) 758 if (!favicon.IsEmpty())
747 return favicon.ToNSImage(); 759 return favicon.ToNSImage();
748 760
749 return defaultImage_; 761 return forADarkTheme ? defaultImageIncognito_ : defaultImage_;
750 } 762 }
751 763
752 - (void)closeFolderAndStopTrackingMenus { 764 - (void)closeFolderAndStopTrackingMenus {
753 showFolderMenus_ = NO; 765 showFolderMenus_ = NO;
754 [self closeAllBookmarkFolders]; 766 [self closeAllBookmarkFolders];
755 } 767 }
756 768
757 - (BOOL)canEditBookmarks { 769 - (BOOL)canEditBookmarks {
758 PrefService* prefs = browser_->profile()->GetPrefs(); 770 PrefService* prefs = browser_->profile()->GetPrefs();
759 return prefs->GetBoolean(bookmarks::prefs::kEditBookmarksEnabled); 771 return prefs->GetBoolean(bookmarks::prefs::kEditBookmarksEnabled);
(...skipping 2327 matching lines...) Expand 10 before | Expand all | Expand 10 after
3087 - (id<BookmarkButtonControllerProtocol>)controllerForNode: 3099 - (id<BookmarkButtonControllerProtocol>)controllerForNode:
3088 (const BookmarkNode*)node { 3100 (const BookmarkNode*)node {
3089 // See if it's in the bar, then if it is in the hierarchy of visible 3101 // See if it's in the bar, then if it is in the hierarchy of visible
3090 // folder menus. 3102 // folder menus.
3091 if (bookmarkModel_->bookmark_bar_node() == node) 3103 if (bookmarkModel_->bookmark_bar_node() == node)
3092 return self; 3104 return self;
3093 return [folderController_ controllerForNode:node]; 3105 return [folderController_ controllerForNode:node];
3094 } 3106 }
3095 3107
3096 @end 3108 @end
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698